Minor refactoring of View\Page\Config\Reader\Body #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No test since the protected method setBodyAttributeToStructure is only called from within the class and the process() return value is never used. |
|
Thanks for your contribution, @Vinai! The team will review it and we will notify you of the results. |
|
Hi @Vinai, please review the PR, and if it is actual, please resubmit into develop with extra description. As for now lib/internal/Magento/Framework/View/Page/Config/Reader/Body.php was changed, and the changes may be outdated. Anyway, thanks for your contribution. Max. |
* Fix typo in method name * Change interpret method return value to conform with Layout\ReaderInterface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.