MC-41359 Fix incorrect setting of the SameSite cookie param #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@viktym could you review? |
hostep
reviewed
Mar 24, 2021
Functional Acceptance Test Results❌ One or more functional acceptance tests have failed. PHP 7.2
PHP 7.3
PHP 7.4
Output for failed tests is below. If many tests have failed only the first 5 will be included. If you need additional information please reach out to the Magento Cloud team for more details. This comment was generated by Jenkins job magento-quality-patches/functional build 56. |
PHP 7.3 CEx235x236p1Cest OutputThis comment was generated by Jenkins job magento-quality-patches/functional build 56. |
PHP 7.3 B2Bx235x236p1Cest OutputThis comment was generated by Jenkins job magento-quality-patches/functional build 56. |
Functional Acceptance Test Results❌ One or more functional acceptance tests have failed. PHP 7.2
PHP 7.3
PHP 7.4
Output for failed tests is below. If many tests have failed only the first 5 will be included. If you need additional information please reach out to the Magento Cloud team for more details. This comment was generated by Jenkins job magento-quality-patches/functional build 57. |
PHP 7.3 B2Bx235x236p1Cest OutputThis comment was generated by Jenkins job magento-quality-patches/functional build 57. |
PHP 7.3 CEx235x236p1Cest OutputThis comment was generated by Jenkins job magento-quality-patches/functional build 57. |
|
Hi @viktym, Unfortunately, test results not clear at all. Also, I didn't find any source code for the tests. Could you check if there any issue with my changes? |
|
Hi @ihor-sviziev |
|
@viktym the pull request successfully imported. |
|
@ihor-sviziev tests were passed on internal PR. On your build, for some reason, your patch was trying to apply on Magento 2.3.6. Maybe the configuration in patches.json was ">=2.3.6 <2.3.7" MQP target release: 1.0.20 |
|
@viktym, here are few examples of how to reproduce an issue: magento/magento2#32462 (comment). I believe it's good enough |
|
Internal PR was merged into the master branch. I'm closing this one. |
|
Just for reference - changes from this PR were merged in ab51bc4 |
magento-cicd2
pushed a commit
that referenced
this pull request
Jun 26, 2021
* 1.0.25 Release * 1.0.25 Release - fixed failed tests * 1.0.25 Release - fixed incorrect version position in structure * 1.0.25 Release - fixed not correct patch versions * 1.0.25 Release - fixed not correct patch versions * 1.0.25 Release - removed one patch * 1.0.25 Release - fixed patch version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Port changes from magento/magento2#32462 that fixes magento/magento2#26377 ( MC-41359 ) for Magento 2.3.6-p1 and 2.4.2
Please note that for Magento 2.3.6-p1, we're not patching the file Magento_PageCache/js/form-key-provider.js as it didn't exist yet.
It was added in the scope of magento/magento2@6f68dc5#diff-fb691f78043f3730b50e6387fc2b9b250a97a808ec7e5412ec404dec5587abd1R303.
The original version was using
$.mage.cookiesthat was already patched in this PR scope.https://github.com/magento/magento2/blob/6f68dc560f4318efec57430fe3903dd308ac83d9/app/code/Magento/PageCache/view/frontend/web/js/page-cache.js#L124
Fixed Issues (if relevant)