This repository has been archived by the owner on Sep 13, 2018. It is now read-only.
we can now configure room deadline in puppet #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitsuta
added a commit
that referenced
this pull request
Aug 16, 2015
we can now configure room deadline in puppet
|
+1 |
|
left some comments in #28, though I think even with docker, puppet will probably stick around in some form to setup config and setup docker, even if it's not the thing installing uber and nginx/etc anymore because that's now being handled inside Dockerfiles |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another field puppetized.
If puppet does stick around (which it probably won't if we move to Docker) then I'd really like to get #28 so that we don't have to constantly make PRs once per config option every time we go to set a variable which isn't puppetized yet. Obviously that ticket is a huge amount of work, so it's not feasible to do it anytime soon, and if we move away from puppet then it'll be a moot point. Still, I think about it longingly every time I go to make a config change and find that the option I want to set isn't puppetized :(