enable band / panels plugin for puppet #78
Conversation
- hook up minimum subset of INI values needed to enable the band/panels plugins - band plugin depends on panels plugin for scheduling - more INI breakout is needed, but this is a good scaffolding for starting that work
| [dates] | ||
| <% if @stage_agreement_deadline %> | ||
| stage_agreement_deadline = <%= @stage_agreement_deadline %> | ||
| <% end -%> |
There was a problem hiding this comment.
there's a lot more to add here to get this working, but it's a good starting point
|
OMHBITY. +1 |
| event_location = "<%= @event_location %>" | ||
| <% end -%> | ||
|
|
||
| <% if @panel_rooms %> |
There was a problem hiding this comment.
Will this work as intended? Keeping in mind that, according to a quick Google search, our empty list is not considered falsey in Ruby.
There was a problem hiding this comment.
Yea, it ends up generating the following line in the INI file because our empty list is truthy in ruby:
puppet config for magstock says:
uber::plugin_panels::panel_rooms: ","
INI looks like:
panel_rooms = ,
If puppet doesn't specify anything, puppet's deftault is 'undef' which means that the configspec.ini value for panel_rooms of "panels_1", "panels_2", "panels_3", "panels_4" will be used instead.
|
merging though it may need DB migrations (maybe not), will check it locally first. |
|
+1 belatedly, though much of this is still somewhat over my head. Like, I understand what I see, but I wouldn't have been able to write it from scratch myself. |
|
btw, this PR replaces #67 however, that PR has a very thorough explanation of why it was done this way and some design considerations. |
this will be obsoleted if/when we do #28 , which we should probably really actually do. it's a decent bandaid for now though.
also FINALLY fixes #55 w00t.