Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSS overrides for cosmo and superhero #1805

Merged
merged 1 commit into from
Nov 26, 2022
Merged

Conversation

phl0
Copy link
Contributor

@phl0 phl0 commented Nov 24, 2022

The two skins cosmo and superhero have a separate CSS for links. This overrides the behaviour for eqsl-green classes so that colors are not overriden (i.e. just being white).

@phl0
Copy link
Contributor Author

phl0 commented Nov 24, 2022

I found no better way. So this is basically what #1801 had already.

@phl0
Copy link
Contributor Author

phl0 commented Nov 24, 2022

@DL3EL I guess this will get merged to fix the two skins. This means you will have to add "!important" to your eqsl and/or other colors in CSS. See the changes in this PR. Found not other way to fix this. Sri

@DL3EL
Copy link

DL3EL commented Nov 24, 2022

Thanks, no problem with that. I will update as soon as it is publicly committed.
Thomas

@phl0
Copy link
Contributor Author

phl0 commented Nov 26, 2022

Roger that. So should be good for merge.

@magicbug magicbug merged commit a6426cd into magicbug:dev Nov 26, 2022
@magicbug
Copy link
Owner

Into the dev branch it goes!

@phl0 phl0 deleted the fixCSS branch November 26, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants