Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CQ Map] Added full screen option #2039

Merged
merged 1 commit into from
Mar 19, 2023
Merged

[CQ Map] Added full screen option #2039

merged 1 commit into from
Mar 19, 2023

Conversation

AndreasK79
Copy link
Contributor

@AndreasK79 AndreasK79 commented Mar 18, 2023 •
edited
Loading

Added full screen plugin from here: https://github.com/brunob/leaflet.fullscreen
image

phl0
phl0 approved these changes Mar 19, 2023
View reviewed changes
Copy link
Contributor

@phl0 phl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tested successfully on my end.

@AndreasK79 AndreasK79 merged commit 5c4af8b into magicbug:dev Mar 19, 2023
@4O4A
Copy link

4O4A commented Mar 20, 2023

I'd like to help, but I don't know where to find new file :)

@phl0
Copy link
Contributor

phl0 commented Mar 20, 2023

I'd like to help, but I don't know where to find new file :)

Which file are you looking for?

@4O4A
Copy link

4O4A commented Mar 20, 2023

cqmap.js --> version with updated plugin.
I suck in versions :)

@phl0
Copy link
Contributor

phl0 commented Mar 20, 2023

It has been merged into dev branch already.

@4O4A
Copy link

4O4A commented Mar 20, 2023

All works fine, thank you!

@AndreasK79
Copy link
Contributor Author

I've added fullscreen a few other places as well.

@AndreasK79 AndreasK79 deleted the cqmap_fullscreen branch June 17, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phl0 phl0 phl0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndreasK79 @4O4A @phl0