From 3434e3c49c008210df9726f10de994994d97e63a Mon Sep 17 00:00:00 2001 From: Paul van Dyk <39598117+PaulPCIO@users.noreply.github.com> Date: Wed, 10 Feb 2021 11:30:08 +0100 Subject: [PATCH] fix: fixes the callback query checks The previous if statement resulted in the emailRedirectLogin being called without magic link being defined. eg; ```js if(magic && router.query.provider) return finishSocialLogin() else return finishEmailRedirectLogin() ``` I should instead read: ```js if(magic){ if(router.query.provider) return finishSocialLogin() else return finishEmailRedirectLogin() } ``` --- pages/callback.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pages/callback.js b/pages/callback.js index 5a098a4..5f33d3d 100644 --- a/pages/callback.js +++ b/pages/callback.js @@ -18,7 +18,7 @@ const Callback = () => { }) ); /* if `provider` is in our query params, the user is logging in with a social provider */ - magic && router.query.provider ? finishSocialLogin() : finishEmailRedirectLogin(); + magic && (router.query.provider ? finishSocialLogin() : finishEmailRedirectLogin()); }, [magic, router.query]); const finishSocialLogin = async () => {