This repository was archived by the owner on Oct 10, 2025. It is now read-only.
Sets EIP712TypedData.Domain properties to optional #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #61083: Dydx EIP712TypedData updates for Magic iOS. |
Member
|
NICE! 🎉 Were you able to test the change by calling the |
Member
|
Looks great! Let's put screenshots with test result in the PR from now. I'll make some PR templates to help us to format it. |
Ethella
approved these changes
Oct 13, 2022
Ariflo
deleted the
ariflores-sc-61083-dydx-EIP712TypedData-updates-for-Magic-ios
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saltproperty as per doc: https://eips.ethereum.org/EIPS/eip-712- bytes32 salt - an disambiguating salt for the protocol. This can be used as a domain separator of last resort.