use a non-emulative Lexer for PhpParser

src/ComposerRequireChecker/Cli/CheckCommand.php

@@ -14,6 +14,7 @@
 use ComposerRequireChecker\JsonLoader;
 use ComposerRequireChecker\UsedSymbolsLocator\LocateUsedSymbolsFromASTRoots;
 use PhpParser\ErrorHandler\Collecting as CollectingErrorHandler;
+use PhpParser\Lexer;
 use PhpParser\ParserFactory;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Helper\Table;
@@ -155,8 +156,8 @@ private function getComposerData(string $jsonFile): array
     private function getASTFromFilesLocator(InputInterface $input): LocateASTFromFiles
     {
         $errorHandler = $input->getOption('ignore-parse-errors') ? new CollectingErrorHandler() : null;
-        $sourcesASTs = new LocateASTFromFiles((new ParserFactory())->create(ParserFactory::PREFER_PHP7), $errorHandler);
-        return $sourcesASTs;
+        $parser = (new ParserFactory())->create(ParserFactory::PREFER_PHP7, new Lexer());
+        return new LocateASTFromFiles($parser, $errorHandler);
     }
 
 

test/ComposerRequireCheckerTest/Cli/CheckCommandTest.php

@@ -5,9 +5,15 @@
 use ComposerRequireChecker\Cli\Application;
 use org\bovigo\vfs\vfsStream;
 use PHPUnit\Framework\TestCase;
+use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Tester\CommandTester;
 
+use function dirname;
+use function file_put_contents;
+use function unlink;
+use function version_compare;
+
 final class CheckCommandTest extends TestCase
 {
 
@@ -122,4 +128,28 @@ public function testSourceFileThatUsesDevDependency(): void
         $this->assertNotEquals(0, $exitCode);
         $this->assertRegExp('/The following unknown symbols were found.*PHPUnit\\\\Framework\\\\TestCase/s', $this->commandTester->getDisplay());
     }
+
+    public function testNoUnknownSymbolsFound(): void
+    {
+        $baseDir = dirname(__DIR__, 2) . '/fixtures/noUnknownSymbols/';
+        $this->commandTester->execute(['composer-json' => $baseDir . 'composer.json']);
+
+        self::assertSame(Command::SUCCESS, $this->commandTester->getStatusCode());
+        self::assertStringContainsString('There were no unknown symbols found.', $this->commandTester->getDisplay());
+    }
+
+    public function testReservedKeywordInPhp8DoesNotThrowExceptionInPhp7(): void
+    {
+        if (version_compare(PHP_VERSION, '8.0.0') >= 0) {
+            self::markTestSkipped('This test does not work in PHP8');
+        }
+        $baseDir = dirname(__DIR__, 2) . '/fixtures/noUnknownSymbols/';
+        $tmpFile = $baseDir . 'src/Match.php';
+        file_put_contents($tmpFile, '<?php class Match { }');
+
+        $this->commandTester->execute(['composer-json' => $baseDir . 'composer.json']);
+
+        unlink($tmpFile);
+        self::assertSame(Command::SUCCESS, $this->commandTester->getStatusCode());
+    }
 }

test/fixtures/noUnknownSymbols/composer.json

@@ -0,0 +1,11 @@
+{
+    "name": "example/library",
+    "require": {
+        "php": "^7.2"
+    },
+    "autoload": {
+        "psr-4": {
+            "Example\\Library\\": "src/"
+        }
+    }
+}

test/fixtures/noUnknownSymbols/src/SomeClass.php

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Example\Library;
+
+use function strlen;
+
+final class SomeClass
+{
+    public function someMethod(string $foo): int
+    {
+        return strlen($foo);
+    }
+}

test/fixtures/noUnknownSymbols/vendor/composer/installed.json

@@ -0,0 +1 @@
+[]