Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psalm patrol #206

Merged
merged 25 commits into from
Nov 27, 2020
Merged

Psalm patrol #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
7bf666f
bump pslam version
DanielBadura Oct 2, 2020
0bdb4de
increase level from 4 to 3
DanielBadura Oct 2, 2020
546fc0c
fix level 3 issues
DanielBadura Oct 2, 2020
12cf63f
increase level from 3 to 2
DanielBadura Oct 2, 2020
c7bc4ec
fix level 2 issues
DanielBadura Oct 2, 2020
f88ec30
remove tests due to usgae with wrong types, upstream phpdoc disallows…
DanielBadura Oct 2, 2020
a39ce2b
add baseline for package version deprecation, cannot bump to composer…
DanielBadura Oct 2, 2020
5331a3a
add testcase for new path in check command if argument is not string
DanielBadura Oct 2, 2020
1b30d1a
increase level from 2 to 1
DanielBadura Oct 2, 2020
5f50628
fix baseline
DanielBadura Oct 2, 2020
323d122
add space
DanielBadura Oct 2, 2020
591b001
add alot of array types
DanielBadura Oct 2, 2020
06aac4e
update baseline with some level 1 errors
DanielBadura Oct 3, 2020
e39219c
remove a superflous return, add a test for JsonLoader
DanielBadura Oct 3, 2020
eed6c01
fix typos
DanielBadura Oct 3, 2020
5626e77
add missing test file
DanielBadura Oct 3, 2020
9c45571
update psalm to ^3.16.0 in lock
DanielBadura Oct 4, 2020
7cda74e
add webmozart/assert as dependecy
DanielBadura Oct 4, 2020
82117c7
use assert to check if file exists and is readable
DanielBadura Oct 4, 2020
135d620
fixed psalm issues after rebasing
DanielBadura Nov 10, 2020
08f8053
cast NodeName to string like it should be done before
DanielBadura Nov 10, 2020
2eb8431
try to resolve the PackageVersion problem but because of the replacem…
DanielBadura Nov 10, 2020
c81fef8
cs fix
DanielBadura Nov 10, 2020
cc302ed
fix psalm issues according to the array
DanielBadura Nov 27, 2020
11f7a50
add composer-runtime-api as a dependency and remove Ocramius/PackageV…
DanielBadura Nov 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,27 @@
<?xml version="1.0" encoding="UTF-8"?>
<files psalm-version="3.12.2@7c7ebd068f8acaba211d4a2c707c4ba90874fa26">
<files psalm-version="3.16@d03e5ef057d6adc656c0ff7e166c50b73b4f48f3">
<file src="src/ComposerRequireChecker/Cli/Application.php">
<DeprecatedClass occurrences="1">
<code>Versions::getVersion('maglnet/composer-require-checker')</code>
</DeprecatedClass>
</file>
<file src="src/ComposerRequireChecker/Cli/CheckCommand.php">
<MixedArgumentTypeCoercion occurrences="2"/>
</file>
<file src="src/ComposerRequireChecker/FileLocator/LocateComposerPackageSourceFiles.php">
<MixedArgument occurrences="4">
<code>$composerData['autoload']['classmap'] ?? []</code>
<code>$composerData['autoload']['files'] ?? []</code>
<code>$composerData['autoload']['psr-0'] ?? []</code>
<code>$composerData['autoload']['psr-4'] ?? []</code>
</MixedArgument>
<MixedArgumentTypeCoercion occurrences="4">
<code>$this-&gt;getFilePaths($composerData['autoload']['classmap'] ?? [], $packageDir)</code>
<code>$this-&gt;getFilePaths($composerData['autoload']['files'] ?? [], $packageDir)</code>
<code>$this-&gt;getFilePaths($composerData['autoload']['psr-0'] ?? [], $packageDir)</code>
<code>$this-&gt;getFilePaths($composerData['autoload']['psr-4'] ?? [], $packageDir)</code>
</MixedArgumentTypeCoercion>
</file>
<file src="src/ComposerRequireChecker/NodeVisitor/DefinedSymbolCollector.php">
<NoInterfaceProperties occurrences="1">
<code>$node-&gt;namespacedName</code>
Expand Down
5 changes: 3 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,10 @@
"php": "7.4.*",
"ext-json": "*",
"ext-phar": "*",
"composer-runtime-api": "^2.0.0",
"nikic/php-parser": "^4.10.2",
"ocramius/package-versions": "^1.9.0",
"symfony/console": "^5.1.8",
"webmozart/assert": "^1.9.1",
"webmozart/glob": "^4.1.0"
},
"require-dev": {
Expand All @@ -40,7 +41,7 @@
"mikey179/vfsstream": "^1.6.8",
"phpstan/phpstan": "^0.12.54",
"phpunit/phpunit": "^9.4.3",
"vimeo/psalm": "^3.12.2"
"vimeo/psalm": "^3.18.2"
},
"config": {
"optimize-autoloader": true,
Expand Down
Loading