Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feldsam/show ban info page #5796

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from

Conversation

feldsam
Copy link
Member

@feldsam feldsam commented Mar 19, 2024

This pull request introduces a significant enhancement to our netfilter functionality, addressing the problem of incorrectly configured devices which could lock out entire company branches. To mitigate this issue and enhance our network security posture, the following changes have been implemented:

  1. Netfilter Modifications: The netfilter image has been updated to always allow TCP traffic on ports 80 and 443. This adjustment ensures that, despite any broad blocking rules, essential web traffic remains uninterrupted. Please note that this change is currently applied only to the IPTables module; integration with NFTables is pending and will require further contributions.

  2. OpenResty Integration: By leveraging the OpenResty nginx image, which includes integrated support for Lua and Redis, I've established a robust mechanism for dynamic response based on IP reputation. Specifically, the nginx location / {} directive now includes a Lua script to check against the F2B_ACTIVE_BANS and F2B_PERM_BANS in Redis. If an IP is found to be blacklisted, the user is redirected to a custom 403 page explaining the block.

  3. Future Enhancements: While the current implementation focuses on notifying users of a block, plans for future updates include the introduction of a self-service unban feature. This capability would allow users to resolve accidental bans autonomously, reducing administrative overhead and improving user experience.

Your feedback and contributions, especially regarding the integration with NFTables and the development of the self-service unban feature, are highly welcomed and appreciated.

Signed-off-by: Kristian Feldsam <feldsam@gmail.com>
Just with behavioural check.

Signed-off-by: Kristian Feldsam <feldsam@gmail.com>
@feldsam
Copy link
Member Author

feldsam commented Mar 20, 2024

I've added a simple self-unban page that features a behavioral check to enhance user autonomy and maintain security. This update allows users to address accidental bans efficiently while ensuring the process isn't exploited by automated systems. Looking forward to your feedback!

@milkmaker
Copy link
Collaborator

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@milkmaker milkmaker added the stale Please update the issue with current status, unclear if it's still open/needed. label May 20, 2024
@feldsam
Copy link
Member Author

feldsam commented May 20, 2024

@DerLinkman @FreddleSpl0it hello, would somebody review this? Thanks!

@milkmaker milkmaker removed the stale Please update the issue with current status, unclear if it's still open/needed. label May 20, 2024
Copy link
Member

@DerLinkman DerLinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need the addition of the NFTables Stuff, but currently no time for that...

@DerLinkman
Copy link
Member

Maybe @tomudding or @amorfo77 can help here.

Otherwise it is still on hold i'm afraid...

@milkmaker
Copy link
Collaborator

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@milkmaker milkmaker added the stale Please update the issue with current status, unclear if it's still open/needed. label Oct 6, 2024
@milkmaker milkmaker closed this Oct 14, 2024
@feldsam
Copy link
Member Author

feldsam commented Oct 14, 2024

Reopen please

@DerLinkman DerLinkman reopened this Oct 15, 2024
@DerLinkman DerLinkman added neverstale Bot doesn't mark the issue or PR as stale and removed stale Please update the issue with current status, unclear if it's still open/needed. labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help-wanted neverstale Bot doesn't mark the issue or PR as stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants