Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encode/decode enhancement #122

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

frankobe
Copy link

@frankobe frankobe commented Nov 3, 2016

Fix 3 encoding/decoding problems during my daily usage of flanker, tests case from real life added

  1. poor support of Chinese encoding including 'gb2312', 'gbk' and 'gb18030'

  2. heavily rely on _guess_and_convert, ignore context-type as demonstrated by test email charset-gb2312.eml

  3. cant handle encode word data corruption caused by encode word separation into multi lines as demonstrated by test case encodedword_test

@mailgun-ci
Copy link

Can one of the admins verify this patch?

@frankobe
Copy link
Author

wonder is this repo actively maintained?

@frankobe frankobe force-pushed the aggregate-encode branch from 09b414d to 08fc30c Compare June 7, 2017 23:28
@frankobe frankobe force-pushed the aggregate-encode branch from ebc3c3a to 34df5f5 Compare June 9, 2017 21:19
@frankobe frankobe force-pushed the aggregate-encode branch from 4b1f4e8 to 17bacd7 Compare June 9, 2017 21:29
@b0d0nne11
Copy link
Contributor

It is still maintained and we're slowly trying to chip away at these older issues. Sorry for letting it languish! If you're still interested could you rebase on master to cleanup the diff and collapse the fix commits?

@frankobe
Copy link
Author

@b0d0nne11 sure, I can do it, need some time to rebase my memory though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants