From 97121353bea29fdeeb1ea20dec41764456d519af Mon Sep 17 00:00:00 2001 From: Marco Otte-Witte Date: Mon, 10 Aug 2020 11:34:00 +0200 Subject: [PATCH 1/3] fix CI config --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f3f818907..e89532bbf 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -88,7 +88,7 @@ jobs: - name: tests run: yarn workspace ${{ matrix.workspace }} ${{ matrix.test-suite }} - continue-on-error: ${{matrix.allow-failure}} + continue-on-error: ${{ matrix.allow-failure }} extra-tests: name: Tests (Floating Dependenies) From 4a0818570443d3a9c0eb5ab4e2dfbd713607616f Mon Sep 17 00:00:00 2001 From: Marco Otte-Witte Date: Mon, 10 Aug 2020 11:56:53 +0200 Subject: [PATCH 2/3] fix capitatilazation of header --- .../tests/unit/authenticators/oauth2-password-grant-test.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/ember-simple-auth/tests/unit/authenticators/oauth2-password-grant-test.js b/packages/ember-simple-auth/tests/unit/authenticators/oauth2-password-grant-test.js index d88c86b9b..e66289d82 100644 --- a/packages/ember-simple-auth/tests/unit/authenticators/oauth2-password-grant-test.js +++ b/packages/ember-simple-auth/tests/unit/authenticators/oauth2-password-grant-test.js @@ -148,7 +148,7 @@ describe('OAuth2PasswordGrantAuthenticator', () => { it('sends an AJAX request to the token endpoint with customized headers', async function() { server.post('/token', (request) => { - expect(request.requestHeaders['x-custom-context']).to.eql('foobar'); + expect(request.requestHeaders['X-Custom-Context']).to.eql('foobar'); return [200, { 'Content-Type': 'application/json' }, '{ "access_token": "secret token!" }']; }); @@ -279,7 +279,7 @@ describe('OAuth2PasswordGrantAuthenticator', () => { await authenticator.authenticate('username', 'password'); expect(false).to.be.true; } catch (error) { - expect(error.headers.get('x-custom-context')).to.eql('foobar'); + expect(error.headers.get('X-Custom-Context')).to.eql('foobar'); } }); }); From 55ad3d3dfcce01c8d18fbffcb2aaa8bccf695c96 Mon Sep 17 00:00:00 2001 From: Marco Otte-Witte Date: Mon, 10 Aug 2020 12:10:39 +0200 Subject: [PATCH 3/3] set default for allow-failure --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e89532bbf..ac36e5e4d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -62,6 +62,7 @@ jobs: - test:one ember-release - test:one ember-beta - test:one ember-canary + allow-failure: [false] include: - test-suite: "test:one ember-canary" allow-failure: true