Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix floating point type (#20) #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix floating point type (#20) #25

wants to merge 2 commits into from

Conversation

krzyc
Copy link

@krzyc krzyc commented Dec 12, 2019

Float fields are truncated. Fixes #20.

@njt1982
Copy link

njt1982 commented Jul 7, 2021

This seem to have worked for me...

 org\majkel\dbase\field\NumericField Object
                (
                    [name:protected] => S_XXXX
                    [length:protected] => 9
                    [decimalCount:protected] => 0
                    [load:protected] => 1
                    [filters:protected] => Array
                        (
                        )

                )

vs

 org\majkel\dbase\field\NumericField Object
                (
                    [name:protected] => S_XXXX
                    [length:protected] => 9
                    [decimalCount:protected] => 2
                    [load:protected] => 1
                    [filters:protected] => Array
                        (
                        )

                )

@jan-ccd
Copy link

jan-ccd commented Aug 15, 2021

Hey, Is there any chance getting this PR merged?
It would be super useful for me.

@krzyc
Copy link
Author

krzyc commented Aug 16, 2021

@majkel89 If some action is needed before merging this PR please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Float numbers truncated
3 participants
@krzyc @njt1982 @jan-ccd