From c442464bd6fed8a16a17ca9a2389c0a473e065a5 Mon Sep 17 00:00:00 2001 From: Dakshesh Jain Date: Fri, 13 Jan 2023 13:07:50 +0530 Subject: [PATCH 1/2] style: changed text and added spinner for signing in loading --- apps/app/pages/signin/index.tsx | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/apps/app/pages/signin/index.tsx b/apps/app/pages/signin/index.tsx index bc729e49b02..de74f3f6ba3 100644 --- a/apps/app/pages/signin/index.tsx +++ b/apps/app/pages/signin/index.tsx @@ -12,6 +12,7 @@ import DefaultLayout from "layouts/default-layout"; import { GoogleLoginButton, GithubLoginButton, EmailSignInForm } from "components/account"; // icons import Logo from "public/logo-with-text.png"; +import { Spinner } from "components/ui"; const { NEXT_PUBLIC_GITHUB_ID } = process.env; @@ -82,8 +83,9 @@ const SignInPage: NextPage = () => { }} > {isLoading && ( -
-

Signing in with Google. Please wait...

+
+

Signing in. Please wait...

+
)}
From 089bda87043be2ce05e6038a44c6aff7f5c9c462 Mon Sep 17 00:00:00 2001 From: Dakshesh Jain Date: Fri, 13 Jan 2023 13:14:14 +0530 Subject: [PATCH 2/2] refractor: removed unused type --- apps/app/pages/signin/index.tsx | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/apps/app/pages/signin/index.tsx b/apps/app/pages/signin/index.tsx index de74f3f6ba3..36ec29d56bd 100644 --- a/apps/app/pages/signin/index.tsx +++ b/apps/app/pages/signin/index.tsx @@ -10,21 +10,13 @@ import authenticationService from "services/authentication.service"; import DefaultLayout from "layouts/default-layout"; // social button import { GoogleLoginButton, GithubLoginButton, EmailSignInForm } from "components/account"; +// ui +import { Spinner } from "components/ui"; // icons import Logo from "public/logo-with-text.png"; -import { Spinner } from "components/ui"; const { NEXT_PUBLIC_GITHUB_ID } = process.env; -// types -type SignIn = { - email: string; - password?: string; - medium?: string; - key?: string; - token?: string; -}; - const SignInPage: NextPage = () => { // router const router = useRouter();