Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase size of filters popup #304

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

Chatewgne
Copy link
Member

@Chatewgne Chatewgne commented Jun 19, 2024

Before :
image

After :
image

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.01%. Comparing base (be35fbc) to head (403b669).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #304   +/-   ##
=======================================
  Coverage   91.01%   91.01%           
=======================================
  Files          32       32           
  Lines        2403     2403           
=======================================
  Hits         2187     2187           
  Misses        216      216           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dtrucs
Copy link
Member

dtrucs commented Jun 19, 2024

It can be problematic to remove this CSS property if you have a form larger than the height of your screen; without he overflow the max-height prop is ignored and the content of the popup window must exceed the screen size.

@dtrucs
Copy link
Member

dtrucs commented Jun 19, 2024

Maybe you can add an extra padding to your input container if the last item contains an input with multiple choices

#mainfilter .form-group > p:last-child:has(.chosen-container-multi) {
  padding-bottom: 12rem;
}

@Chatewgne Chatewgne changed the title Change CSS overflow in filters popup Increase size of filters popup Jun 27, 2024
@Chatewgne Chatewgne merged commit fdeafc3 into master Jun 28, 2024
12 checks passed
@Chatewgne Chatewgne deleted the impr_popup_select_overflow branch June 28, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants