Skip to content

Commit

Permalink
Remove culling property (#356)
Browse files Browse the repository at this point in the history
* Removes code related to culling parameter.

ignition-rendering2 did not incoroporate the culling to materials
and it is causing Scene3D plugin not to properly decode the URI
and convert it into a file path.

Co-authored-by: Steve Peters <scpeters@openrobotics.org>
  • Loading branch information
agalbachicar and scpeters authored Feb 24, 2021
1 parent e0f78a1 commit 7717aeb
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions delphyne_gui/visualizer/render_widget.cc
Original file line number Diff line number Diff line change
Expand Up @@ -379,13 +379,6 @@ ignition::rendering::VisualPtr RenderWidget::RenderMesh(const ignition::msgs::Vi
std::max(maxXYZ.Y() + _vis.pose().position().y(), maxBBScene.Y()),
std::max(maxXYZ.Z() + _vis.pose().position().z(), maxBBScene.Z()));

if (mesh_uri.Query().Str().find("culling=off") != std::string::npos) {
DELPHYNE_VALIDATE(mesh->GeometryCount() == 1, std::runtime_error, "Expected one geometry.");
auto subMesh = mesh->GeometryByIndex(0);
/* TODO: Enable once ignition-rendering2 supports culling
subMesh->Material()->SetCulling(ignition::rendering::CullMode::CM_NONE);*/
}

setPoseFromMessage(_vis, mesh);

return mesh;
Expand Down

0 comments on commit 7717aeb

Please sign in to comment.