Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display plugins: make ignition::rendering API calls during ignition::gui::events::Render callback #393

Closed
2 tasks
scpeters opened this issue May 5, 2021 · 1 comment

Comments

@scpeters
Copy link
Contributor

scpeters commented May 5, 2021

After noting some race conditions in the agent info display plugin when clicking the visibility checkbox ( #386 (comment) ), we found the pattern for making ignition::rendering calls from from the screenshot example. The approach is to install an event filter for the MainWindow and then make all ignition::rendering API calls from the eventFilter callback if the event is of type ignition::gui::events::Render. This approach can replace the use of a timer for initializing the rendering objects (see a74261c for example).

The following plugins have rendering API calls outside the eventFilter that could be updated:

@francocipollone
Copy link
Collaborator

Closing as plugins were modified to follow this pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants