Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creates Gallery. #7

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Creates Gallery. #7

merged 1 commit into from
Oct 22, 2020

Conversation

francocipollone
Copy link
Collaborator

Related to #3

@francocipollone francocipollone marked this pull request as ready for review October 21, 2020 14:31
@francocipollone francocipollone mentioned this pull request Oct 21, 2020
Open
8 tasks
@agalbachicar
Copy link
Collaborator

The gallery looks really great but the weight of the gifs is considerable. Per f2f chat, @francocipollone will evaluate webm videos and embedded html in .rst files makes the difference.

@francocipollone francocipollone force-pushed the francocipollone/add_gallery branch from f824473 to 46c3801 Compare October 22, 2020 14:18
@francocipollone
Copy link
Collaborator Author

The gallery looks really great but the weight of the gifs is considerable. Per f2f chat, @francocipollone will evaluate webm videos and embedded html in .rst files makes the difference.

All GIFs were removed and .webm videos were added instead, it is great also because the quality of the video is way better than the quality of the GIFs. The size of the repo was reduced from 110 mb to 35 mb.

agalbachicar
agalbachicar approved these changes Oct 22, 2020
View reviewed changes
Copy link
Collaborator

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francocipollone francocipollone merged commit d0ef8c5 into main Oct 22, 2020
@francocipollone francocipollone deleted the francocipollone/add_gallery branch October 22, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agalbachicar agalbachicar agalbachicar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francocipollone @agalbachicar