Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade google style format to 1.14.0 and support for java 17 #29

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Upgrade google style format to 1.14.0 and support for java 17 #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
865b1a7
Use the list of files supplied by pre-commit
daltonfury42 Jun 5, 2020
9c63085
updgrade the java code format version
Jan 26, 2022
4aa3f1c
Merge pull request #1 from Spotnana-Tech/v113
GauravSpotnana Jan 26, 2022
4caf6b8
Support for jdk 17
debraj-spotnana Dec 14, 2022
b7bb355
Update google format to 1.14
debraj-spotnana Dec 14, 2022
16fd950
Fix version
debraj-spotnana Dec 14, 2022
73f92eb
Merge pull request #2 from Spotnana-Tech/v114
debraj-spotnana Dec 14, 2022
3929eea
Fix typo in add-exports option
debraj-spotnana Dec 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ repos:
sha: b7e9e7fcba4a5aea463e72fe9964c14877bd8130
hooks:
- id: google-style-java
files: \.java$
```

*Note*: this file stores Google's code style formatter jar in a `.cache/`
Expand Down
21 changes: 15 additions & 6 deletions format-code.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,22 @@
#!/usr/bin/env sh
mkdir -p .cache
cd .cache
if [ ! -f google-java-format-1.7-all-deps.jar ]
if [ ! -f google-java-format-1.14.0-all-deps.jar ]
then
curl -LJO "https://github.com/google/google-java-format/releases/download/google-java-format-1.7/google-java-format-1.7-all-deps.jar"
chmod 755 google-java-format-1.7-all-deps.jar
curl -LJO "https://github.com/google/google-java-format/releases/download/v1.14.0/google-java-format-1.14.0-all-deps.jar"
chmod 755 google-java-format-1.14.0-all-deps.jar
fi
cd ..

changed_java_files=$(git diff --cached --name-only --diff-filter=ACMR | grep ".*java$" )
echo $changed_java_files
java -jar .cache/google-java-format-1.7-all-deps.jar --replace $changed_java_files
java \
--add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED \
--add-exports jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED \
--add-exports jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED \
--add-exports jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED \
--add-exports jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED \
--add-exports jdk.compiler/com.sun.tools.javac.processing=ALL-UNNAMED \
--add-exports jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED \
--add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED \
--add-opens jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED \
--add-opens jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED \
-jar .cache/google-java-format-1.14.0-all-deps.jar --replace $@