Add support for netrc files as a secondary fallback tier #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baszalmstra
reviewed
Nov 7, 2023
crates/rattler_networking/src/authentication_storage/netrc_storage.rs
Outdated
Show resolved
Hide resolved
crates/rattler_networking/src/authentication_storage/netrc_storage.rs
Outdated
Show resolved
Hide resolved
crates/rattler_networking/src/authentication_storage/netrc_storage.rs
Outdated
Show resolved
Hide resolved
crates/rattler_networking/src/authentication_storage/netrc_storage.rs
Outdated
Show resolved
Hide resolved
|
@baszalmstra feel free to take this one over |
|
@mariusvniekerk I took the liberty to refactor the code slightly. Let me know what you think! If you're happy then we can merge. |
baszalmstra
approved these changes
Dec 7, 2023
|
I brought this PR up to date with the latest changes in |
|
okay merged up |
|
Will merge after checks have ran! |
|
Ill fix the issues tomorrow! |
|
Okaydokey! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to address prefix-dev/pixi#416