Trailing space in CAP NAK

[progval]

At the end of CAP NAK responses, Mammon adds a trailing space:

• mammon/mammon/capability.py

  Line 101 in ab9a4e3

  cli.dump_numeric('CAP', ['NAK', args + ' '])

• mammon/mammon/capability.py

  Line 126 in ab9a4e3

  cli.dump_numeric('CAP', ['ACK', ' '.join(cap_add) + ' -'.join(cap_del) + ' '])

Why?

Also, the spec states “The argument of the NAK subcommand MUST consist of at least the first 100 characters of the capability list in the REQ subcommand which triggered the NAK.”, and this space is not in the original message, so to my understanding, this is invalid.

[progval]

Note: git blame says: 45b0c5f

[DanielOaks]

If mIRC's fixed their client, we can take that out. We'll do some testing and see if it's still required!

[Mikaela]

I think this is breaking ZNC as when I connect I see:

2015-12-20 09:46:16+0200 -- *: C :Unknown command
2015-12-20 09:46:16+0200 -- *: AP :Unknown command
2015-12-20 09:46:16+0200 -- Welcome to the dereferenced.org IRC Network, Mikaela!mikaela@Ace-of-Diamonds.GirlsLikeUs.mikaela.info

And when I run /cap with WeeChat, I see just list of what ZNC supports.

2015-12-20 09:50:34+0200 -- irc: client capability, server supports: batch cap-notify echo-message multi-prefix server-time userhost-in-names znc.in/batch znc.in/playback znc.in/self-message znc.in/server-time-iso
2015-12-20 09:50:34+0200 -- irc: client capability, currently enabled: cap-notify multi-prefix server-time userhost-in-names

[Mikaela]

No, sorry, I missed the "NAK" in the tittle, I am opening a separate issue.