Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly pin libabseil <20240722.0 #2096

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

G-D-Petrov
Copy link
Collaborator

@G-D-Petrov G-D-Petrov commented Dec 30, 2024

Reference Issues/PRs

What does this implement or fix?

Newest build of the libabseil feedstock is not linking correctly with libprotobuf.
See this build for example, error is:

dyld[7654]: Symbol not found: __ZN4absl12lts_2024072212log_internal10LogMessagelsIiLi0EEERS2_RKT_
201
    Referenced from: <64A954D4-9681-37F3-97E6-0599C06DFC5B> /Users/runner/micromamba/envs/arcticdb/lib/libprotoc.28.2.0.dylib
202
    Expected in:     <E99B267F-7144-31DD-A5D4-F5B0B82894DA> /Users/runner/micromamba/envs/arcticdb/lib/libabsl_log_internal_message.2407.0.0.dylib

This PR is pinning libabseil to the previous version.

N.B.: The previous build (same version) of libabseil was linking correctly.

Any other comments?

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings, documentation and copyright notice?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

@G-D-Petrov G-D-Petrov requested a review from jjerphan December 30, 2024 13:18
Copy link
Collaborator

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is due to conda-forge/abseil-cpp-feedstock#87, which might soon be resolved.

PS: the failures on Windows are unrelated.

Copy link
Collaborator

@maxim-morozov maxim-morozov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@G-D-Petrov G-D-Petrov merged commit 2f6e03c into master Jan 2, 2025
123 of 125 checks passed
@G-D-Petrov G-D-Petrov deleted the fix_conda_mac_build branch January 2, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants