From 1a4959d73d26f5b922c76e99cd07e2ed6ad268e2 Mon Sep 17 00:00:00 2001 From: Alexis Placet Date: Mon, 8 Apr 2024 15:58:33 +0200 Subject: [PATCH] Add TODO --- include/sparrow/typed_array.hpp | 1 - test/test_typed_array.cpp | 4 +++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/include/sparrow/typed_array.hpp b/include/sparrow/typed_array.hpp index 3457808d..16f34c2b 100644 --- a/include/sparrow/typed_array.hpp +++ b/include/sparrow/typed_array.hpp @@ -43,7 +43,6 @@ template > class typed_array { public: - using layout_type = L; using reference = typename layout_type::reference; diff --git a/test/test_typed_array.cpp b/test/test_typed_array.cpp index 4c78679c..f4278456 100644 --- a/test/test_typed_array.cpp +++ b/test/test_typed_array.cpp @@ -40,7 +40,7 @@ namespace ad.buffers.push_back(b); ad.length = n; ad.offset = offset; - ad.child_data.push_back(array_data()); + ad.child_data.emplace_back(); return ad; } @@ -91,6 +91,8 @@ TEST_SUITE("typed_array") CHECK_EQ(typed_array_empty.cbegin(), typed_array_empty.cend()); } + // TODO: Add tests for const_iterator: cbegin, cend + TEST_CASE("bitmap") { const auto array_data = make_test_array_data(10, 1);