Improve Screenshot Detection by Modifying capture-screenshot.yml #1007
+43
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nclude GDI, GDIP and DirectX API calls
Improve Screenshot Detection by Modifying capture-screenshot.yml
Comment on lines
51
to
68
| - and: | ||
| - or: | ||
| - api: "GetDC" | ||
| - and: | ||
| - api: "CreateDC" | ||
| - optional: | ||
| - string: "DISPLAY" | ||
| - or: | ||
| - and: | ||
| - api: "SelectObject" | ||
| - api: "DrawText" | ||
| - and: | ||
| - api: "CreateCompatibleDC" | ||
| - api: "CreateCompatibleBitmap" | ||
| - or: | ||
| - api: "BitBlt" | ||
| - api: "StretchBlt" | ||
| - api: "PrintWindow" |
There was a problem hiding this comment.
some of this seems to be duplicated from above, right? would you please merge the logic where reasonable?
There was a problem hiding this comment.
Hello @williballenthin ,
I've tried to remove the duplicated parts of the code and committed the changes. Please let me know if further improvements are required.
akh7177
force-pushed
the
add-screenshot-rule
branch
from
adb3858 to
4cd4879
Compare
akh7177
force-pushed
the
add-screenshot-rule
branch
from
9fe63a9 to
ea56ada
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added GDI, GDIP, and DirectX API calls to improve detection accuracy for various screenshot capture methods.
This detects screenshot capture that uses GDI+ routines as well as CreateDC with other arguments along with DISPLAY. The test files include two executables that demonstrate the improved detection.
closes#981