Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix issue with browser build after upgrading @rollup/plugin-commonjs #1408

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

manferlo81
Copy link
Owner

@manferlo81 manferlo81 commented Oct 10, 2024

Browser build fails when trying to bundle commonjs module from node_modules due to a change in @rollup/plugin-commonjs

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.46%. Comparing base (e450aa4) to head (bd17e14).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1408   +/-   ##
=======================================
  Coverage   99.46%   99.46%           
=======================================
  Files          41       41           
  Lines         556      556           
  Branches      139      139           
=======================================
  Hits          553      553           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manferlo81 manferlo81 merged commit ee617e4 into main Oct 10, 2024
4 checks passed
@manferlo81 manferlo81 deleted the browser-build branch October 10, 2024 05:00
@manferlo81 manferlo81 added bug Something isn't working fix A fix labels Oct 10, 2024
@manferlo81 manferlo81 self-assigned this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix A fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant