Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not valid email #43

Open
samnite opened this issue Oct 8, 2019 · 6 comments
Open

Not valid email #43

samnite opened this issue Oct 8, 2019 · 6 comments

Comments

@samnite
Copy link

samnite commented Oct 8, 2019

validator.validate("test@email.comdddddd"); // return true

@isabelamaro-hotmart
Copy link

isabelamaro-hotmart commented Oct 14, 2019

yeah, it doesn't check the TLDs from iana
https://data.iana.org/TLD/tlds-alpha-by-domain.txt

@WillPapper
Copy link

@manishsaraan If someone submitted a pull request for domain validation (disabled by default, enabled by an optional function parameter), would you accept it? It would include the IANA list. Could be helpful for some users, even though it's separate from the RFC.

I'd be interested in working on it if it would match the goals of the project.

@manishsaraan
Copy link
Owner

Thanks for suggestion @wpapper . Validating domains is not main goal of this project but i agree with your suggestion to add options to enable it. I will happily merge pr for this feature.

@bradisbell
Copy link

If you do this, please do make it optional. Remember, there are potentially private domains that are perfectly valid. test@email.comdddddd is valid depending on the context.

@wahjay
Copy link

wahjay commented Dec 21, 2020

sdfsf@g.m.a.i.l.c.om is evaluated to be true, which should be false.

@francisleigh
Copy link

validator.validate('crack_nicolas@yahoo.fr0033') returns true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants