Fix Swift 3.1 compatibility #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsudekum
suggested changes
Apr 2, 2017
| @@ -1 +1 @@ | |||
| github "AliSoftware/OHHTTPStubs" "swift-3.0" | |||
| github "AliSoftware/OHHTTPStubs" "master" | |||
There was a problem hiding this comment.
We aren’t pinning to master. See Cartfile.resolved, which specifies the exact commit hash that carthage bootstrap will always fetch, regardless of newer commits on master in the future. This just specifies our intent so that we can easily carthage update to intentionally grab the latest master in the future.
I’m checking this change in now because AliSoftware/OHHTTPStubs#240 has landed and the Swift 3 branch will go away soon. Once that happens, this repository will be stranded; carthage update will error out until this PR is merged.
bsudekum
approved these changes
Apr 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved some Swift 3.1 compiler warnings in unit test code. Some optionals should’ve been force-unwrapped because they’d only be used if the optional turned out to be
nil.Also updated dependencies.
/cc @bsudekum