Add has / !has operators #15
Conversation
|
👍 |
| t.equal(f({properties: {foo: true}}), true); | ||
| t.equal(f({properties: {foo: false}}), true); | ||
| t.equal(f({properties: {foo: null}}), true); | ||
| t.equal(f({properties: {foo: undefined}}), false); |
There was a problem hiding this comment.
I'd expect this to be true.
|
This PR is blocked on a decision about how the Open questions:
|
|
Let's go with the definitions you've chosen:
We may add explicit |
|
👋 @lucaswoj - this is going to be super useful to find stats with https://github.com/mapbox/osm-tag-stats (mapbox/osm-tag-stats#2) . Will this get merged soon? |
|
@arunasank I'll get this into the next release! |
|
With humility and hindsight, I think @jfirebaugh's proposed definitions for |
| } | ||
|
|
||
| function compareDescending(a, b) { | ||
| return a - b; |
There was a problem hiding this comment.
This doesn't work for strings.
There was a problem hiding this comment.
How so? I still see a - b which returns NaN for strings.
There was a problem hiding this comment.
😞 It got lost in the rebase shuffle. 😄 Fixed now!
Ah, ok, I'm fine with that too. 😄 For those following along, the behavior in question is "should |
|
Cleaned up the commit history and addressed #15 (comment). Ready to 🚢? |
|
🚢 |
ref mapbox/mapbox-gl-style-spec#364
This will require a minor version bump.
cc @mourner @jfirebaugh @ansis
Todo
feature-filterversion https://www.npmjs.com/package/feature-filtermapbox-gl-style-specAdd support for has / !has operators mapbox-gl-style-spec#451feature-filterandmapbox-gl-style-specin GL JS