Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valhalla support #347

Open
xdmiodz opened this issue Feb 14, 2019 · 2 comments
Open

Valhalla support #347

xdmiodz opened this issue Feb 14, 2019 · 2 comments
Labels
improvement Improvement for an existing feature.

Comments

@xdmiodz
Copy link

xdmiodz commented Feb 14, 2019

Hi! Since you moved to Valhalla, according to your blog posts, is there a plan to support it in the SDK? As far as I can see, the supported API in this SDK is still OSRM-like, and differs from what Valhalla supports at the moment
@1ec5 1ec5 added the improvement Improvement for an existing feature. label Jul 26, 2019
@1ec5
Copy link
Contributor

1ec5 commented Jul 26, 2019

The iOS navigation SDK supports Valhalla for offline routing via the MapboxNavigationNative framework. At the moment, MapboxDirections.swift only supports a Valhalla server endpoint if that endpoint translates the requests and responses between OSRM format and Valhalla format, but there’s no dedicated support for a raw Valhalla endpoint at the moment.

/ref #121

@1ec5 1ec5 closed this as completed Jul 26, 2019
@1ec5 1ec5 reopened this Jul 26, 2019
@1ec5
Copy link
Contributor

1ec5 commented Dec 28, 2019

#393 added initializers for Route, RouteLeg, and RouteStep that you can use as a workaround to transform raw Valhalla responses to type-safe model objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Improvement for an existing feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xdmiodz @1ec5