Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Waypoint.separatesLegs results in mismatched waypoints in RouteLeg #356

Closed
1ec5 opened this issue Feb 26, 2019 · 0 comments · Fixed by #358
Closed

Waypoint.separatesLegs results in mismatched waypoints in RouteLeg #356

1ec5 opened this issue Feb 26, 2019 · 0 comments · Fixed by #358
Assignees
@1ec5
Labels
bug

Comments

@1ec5
Copy link
Contributor

1ec5 commented Feb 26, 2019

If a RouteOptions has multiple waypoints, and all the intermediate waypoints have separatesLegs set to true, the resulting route’s leg’s destination waypoint corresponds in part to one of the intermediate waypoints in the RouteOptions, rather than the final waypoint. This mismatch occurs because of deserialization code that accesses RouteOptions.waypoints without filtering on separatesLegs. This bug was introduced as part of the original via points implementation in #340.
@1ec5 1ec5 added the bug label Feb 26, 2019
@1ec5 1ec5 self-assigned this Feb 26, 2019
@1ec5 1ec5 changed the title RouteOptions.separatesLegs results in mismatched waypoints in RouteLeg Waypoint.separatesLegs results in mismatched waypoints in RouteLeg Feb 26, 2019
@1ec5 1ec5 mentioned this issue Feb 26, 2019
Merged
@1ec5 1ec5 closed this as completed in #358 Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@1ec5 1ec5

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consistently filter waypoints by leg separation mapbox/mapbox-directions-swift
1 participant
@1ec5