Added allowsArrivingOnOppositeSide #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederoni
force-pushed
the
fred/approaches
branch
4 times, most recently
from
297495c to
fa3cf9a
Compare
frederoni
commented
Aug 23, 2018
MapboxDirections/MBWaypoint.swift
Outdated
| */ | ||
| @objc public init(coordinate: CLLocationCoordinate2D, coordinateAccuracy: CLLocationAccuracy = -1, name: String? = nil) { | ||
| @objc public init(coordinate: CLLocationCoordinate2D, coordinateAccuracy: CLLocationAccuracy = -1, name: String? = nil, allowsArrivingOnOppositeSide: Bool = true) { |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
frederoni
force-pushed
the
fred/approaches
branch
2 times, most recently
from
5123b06 to
46379a8
Compare
1ec5
reviewed
Aug 28, 2018
MapboxDirections/MBWaypoint.swift
Outdated
| @@ -9,6 +9,16 @@ open class Waypoint: NSObject, NSCopying, NSSecureCoding { | |||
| return true | |||
| } | |||
|
|
|||
| /// :nodoc: | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
MapboxDirections/MBWaypoint.swift
Outdated
| */ | ||
| @objc public init(coordinate: CLLocationCoordinate2D, coordinateAccuracy: CLLocationAccuracy = -1, name: String? = nil) { | ||
| @objc public init(coordinate: CLLocationCoordinate2D, coordinateAccuracy: CLLocationAccuracy = -1, name: String? = nil, allowsArrivingOnOppositeSide: Bool = true) { |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
MapboxDirections/MBWaypoint.swift
Outdated
| /** | ||
| A boolean value indicating whether arriving on opposite side is allowed. | ||
|
|
||
| This parameter can only be used in combination with `RouteOptions.includesSteps` = true. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
frederoni
force-pushed
the
fred/approaches
branch
3 times, most recently
from
d65b327 to
cf4b16b
Compare
akitchen
approved these changes
Sep 5, 2018
1ec5
approved these changes
Sep 5, 2018
| routeOptions.includesSteps = true | ||
| let params = routeOptions.params | ||
| let approaches = params.filter { $0.name == "approaches" }.first! | ||
| XCTAssert(approaches.value! == "unrestricted;curb;unrestricted", "waypoints[1] should be restricted to curb") |
There was a problem hiding this comment.
Nit: use XCTAssertEqual(_:_:) for a more precise assertion message.
frederoni
force-pushed
the
fred/approaches
branch
from
cf4b16b to
ead055b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #280 support
approachesURL query parameter./cc @1ec5 @akitchen