Waypoint targets #326
Merged
Waypoint targets #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
force-pushed
the
1ec5-waypoint-targets
branch
from
78dbc84 to
6eabc78
Compare
1ec5
commented
Dec 12, 2018
| @@ -328,7 +328,7 @@ open class DirectionsOptions: NSObject, NSSecureCoding, NSCopying { | |||
| An array of directions query strings to include in the request URL. | |||
| */ | |||
| internal var queries: [String] { | |||
| return waypoints.compactMap { return "\($0.coordinate.longitude.rounded(to: 1e6)),\($0.coordinate.latitude.rounded(to: 1e6))" } | |||
| return waypoints.compactMap{ $0.coordinate.stringForRequestURL } | |||
There was a problem hiding this comment.
Note the following edge case: if the developer specifies three waypoints and one of them is invalid, this library previously sent a request with all three waypoints, all but guaranteeing an error in the response. Now it sends only two of the waypoints, which may return a valid response (ignoring the invalid coordinate). However, if the invalid waypoint had the name or targetCoordinate property set, then there would be a mismatch between the path and query parameters in the request URL, resulting in a different error than before in the response.
1ec5
force-pushed
the
1ec5-waypoint-targets
branch
from
6eabc78 to
3257d18
Compare
Added the Waypoint.targetCoordinate property corresponding to the Directions API’s waypoint_targets property. Added unit tests of copying and coding waypoints, as well as specifying waypoint_targets and other waypoint properties in conjunction with a RouteOptions object. Added documentation associating some properties with their API counterparts for discoverability.
1ec5
force-pushed
the
1ec5-waypoint-targets
branch
from
3257d18 to
6a2a707
Compare
|
Tests were failing because of a broken file reference; fixed in 6a2a707. |
frederoni
approved these changes
Dec 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
Waypoint.targetCoordinateproperty corresponding to the Directions API’swaypoint_targetsproperty, which specifies a more specific destination location for arrival instructions.Fixed an issue where the
Waypoint.allowsArrivingOnOppositeSideproperty was not copied when copying aWaypointobject. Added unit tests of copying and coding waypoints, as well as specifyingtargetCoordinateand other waypoint properties in conjunction with a RouteOptions object.Added documentation associating some properties with their API counterparts for discoverability.
/cc @mapbox/navigation-ios @danesfeder @danpaz