Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send large payloads in POST requests #341

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Send large payloads in POST requests #341

merged 1 commit into from
Feb 8, 2019

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Feb 8, 2019

Unified RouteOptions and MatchOptions URL and URL request creation logic. Now the decision of whether to send a GET or POST request is based on the overall URL length, not based on the API endpoint.

Fixed an issue where waypoint names were left unescaped in the body of a POST request to the Map Matching API.

Added methods to get a request or request URL appropriate to the HTTP request method being used.

Fixes #338.

/cc @mapbox/navigation-ios @danpat

Unified RouteOptions and MatchOptions URL and URL request creation logic. Now the decision of whether to send a GET or POST request is based on the overall URL length, not based on the API endpoint.

Fixed an issue where waypoint names were left unescaped in the body of a POST request to the Map Matching API.

Added methods to get a request or request URL appropriate to the HTTP request method being used.
@1ec5 1ec5 added the improvement Improvement for an existing feature. label Feb 8, 2019
@1ec5 1ec5 self-assigned this Feb 8, 2019
@1ec5 1ec5 requested a review from JThramer February 8, 2019 22:34
Copy link
Contributor

@JThramer JThramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

POSTman approved. ✅

@1ec5 1ec5 merged commit 43c0c45 into master Feb 8, 2019
@1ec5 1ec5 deleted the 1ec5-parcel-post-338 branch February 8, 2019 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement for an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants