Add support for speed limits via maxspeed annotations. #367
Conversation
|
This is a revival of #250. |
MapboxDirections/MBSpeedLimit.swift
Outdated
| /** | ||
| Indicates the road segment uses kilometers per hour for measuring speed limits. | ||
| */ | ||
| case kilometersPerHour |
There was a problem hiding this comment.
Argh, it would be great if we could just use Measurement along with UnitSpeed.kilometersPerHour, but alas we still support iOS 9.0 (along with macOS 10.11.0, tvOS 9.0, and watchOS 2.0). I’m chomping at the bit to drop iOS 9 support.
/cc @mapbox/navigation-ios
There was a problem hiding this comment.
A proposed change to the Directions API would add information about locally relevant units to each step, making this class somewhat redundant. We could store the speed limit annotations as CLLocationSpeeds (converting everything to meters per second). Then client code could losslessly convert back to kilometers per hour or miles per hour as indicated by the step.
avi-c
requested review from
JThramer and
vincethecoder
and removed request for
JThramer
1ec5
force-pushed
the
maxspeedAnnotations
branch
2 times, most recently
from
01a7be6 to
4682568
Compare
|
I revived #250 and rebased and retargeted this PR atop it, because that PR already had tests and handled Autobahns correctly. |
1ec5
force-pushed
the
maxspeedAnnotations
branch
from
4682568 to
d723ec9
Compare
There was a problem hiding this comment.
Going to handle #367 (comment) and #367 (comment) as to-do items for landing #250.
Include SDK/API support for speed limits from the Directions API via the maxspeed annotations in the directions response.