Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public Response Types #406

Merged
merged 25 commits into from
Apr 4, 2020
Merged

Public Response Types #406

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
7db34bc
WIP: Surfacing `MapMatchingResponse` and `RouteResponse` as public ty…
Jan 17, 2020
6edcb84
Adding error-case initializer for RouteResponse/MapMatchingResponse
Jan 17, 2020
77f075b
WIP: Removing options object from models, encapsulating authenticatio…
Jan 25, 2020
ee31e7f
WIP: Integrating credentials.
Jan 27, 2020
30b19dc
WIP: cutting down on errors
Jan 30, 2020
2566411
WIP: Fixed all compiler errors, Response model is now coherent, need …
Feb 7, 2020
48abd96
Fixing more tests, three to go.
Feb 10, 2020
d98e073
Fixing remaining tests.
Feb 13, 2020
efb5f2e
Fixing issue where SPM would fail compilation.
Feb 13, 2020
6448a27
Applying same SPM fix to MapMatchingResponse
Feb 13, 2020
288d8af
removing redundant logic
Feb 13, 2020
4e59896
Fixing issue where model mismatch results in a silent fail by propaga…
Feb 13, 2020
8c7b29d
Adding documentation, and test change.
Feb 17, 2020
9a5b4ad
Merge branch 'master' into jerrad/directions-calculate-interface
Feb 17, 2020
49ad7d9
Adding test coverage
Feb 17, 2020
a024d57
Adding offline error case, polish to remaining tests and adding a bit…
Feb 17, 2020
1d23371
Fixing final remaining issues
Feb 17, 2020
63b1941
Just kidding, found some more. I think we're now ready for review.
Feb 17, 2020
65e5e22
typo
Feb 17, 2020
750be24
Implementing error case that wraps any kind of URLError-based network…
Feb 17, 2020
72a85fc
Fixing broken test case
Feb 17, 2020
2243678
Implementing suggestion from @SebastianOsinski to remove dead code pa…
Feb 18, 2020
7c3644f
Removing extraneous optional.
Feb 18, 2020
5065b92
Adding documentation for `Weight`
Apr 3, 2020
a6607fb
Adding simple test for DirectionsCredentials
Apr 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 10 additions & 20 deletions MapboxDirections.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,14 +63,10 @@
439255792344113D006EEE88 /* DirectionsError.swift in Sources */ = {isa = PBXBuildFile; fileRef = 4392557523440EC2006EEE88 /* DirectionsError.swift */; };
4392557A2344113E006EEE88 /* DirectionsError.swift in Sources */ = {isa = PBXBuildFile; fileRef = 4392557523440EC2006EEE88 /* DirectionsError.swift */; };
4392557B2344113F006EEE88 /* DirectionsError.swift in Sources */ = {isa = PBXBuildFile; fileRef = 4392557523440EC2006EEE88 /* DirectionsError.swift */; };
43F89F932350F952007B591E /* MatchResponse.swift in Sources */ = {isa = PBXBuildFile; fileRef = 43F89F922350F952007B591E /* MatchResponse.swift */; };
43F89F942350F952007B591E /* MatchResponse.swift in Sources */ = {isa = PBXBuildFile; fileRef = 43F89F922350F952007B591E /* MatchResponse.swift */; };
43F89F952350F952007B591E /* MatchResponse.swift in Sources */ = {isa = PBXBuildFile; fileRef = 43F89F922350F952007B591E /* MatchResponse.swift */; };
43F89F962350F952007B591E /* MatchResponse.swift in Sources */ = {isa = PBXBuildFile; fileRef = 43F89F922350F952007B591E /* MatchResponse.swift */; };
43F89F98235778DE007B591E /* MapMatchingResponse.swift in Sources */ = {isa = PBXBuildFile; fileRef = 43F89F97235778DE007B591E /* MapMatchingResponse.swift */; };
43F89F99235778DE007B591E /* MapMatchingResponse.swift in Sources */ = {isa = PBXBuildFile; fileRef = 43F89F97235778DE007B591E /* MapMatchingResponse.swift */; };
43F89F9A235778DE007B591E /* MapMatchingResponse.swift in Sources */ = {isa = PBXBuildFile; fileRef = 43F89F97235778DE007B591E /* MapMatchingResponse.swift */; };
43F89F9B235778DE007B591E /* MapMatchingResponse.swift in Sources */ = {isa = PBXBuildFile; fileRef = 43F89F97235778DE007B591E /* MapMatchingResponse.swift */; };
43F89F932350F952007B591E /* MapMatchingResponse.swift in Sources */ = {isa = PBXBuildFile; fileRef = 43F89F922350F952007B591E /* MapMatchingResponse.swift */; };
43F89F942350F952007B591E /* MapMatchingResponse.swift in Sources */ = {isa = PBXBuildFile; fileRef = 43F89F922350F952007B591E /* MapMatchingResponse.swift */; };
43F89F952350F952007B591E /* MapMatchingResponse.swift in Sources */ = {isa = PBXBuildFile; fileRef = 43F89F922350F952007B591E /* MapMatchingResponse.swift */; };
43F89F962350F952007B591E /* MapMatchingResponse.swift in Sources */ = {isa = PBXBuildFile; fileRef = 43F89F922350F952007B591E /* MapMatchingResponse.swift */; };
8D381B611FD9F5B1008D5A58 /* noDestinationName.json in Resources */ = {isa = PBXBuildFile; fileRef = 8D381B601FD9F5B1008D5A58 /* noDestinationName.json */; };
8D381B631FDB01D1008D5A58 /* apiDestinationName.json in Resources */ = {isa = PBXBuildFile; fileRef = 8D381B621FDB01D1008D5A58 /* apiDestinationName.json */; };
8D381B641FDB0898008D5A58 /* noDestinationName.json in Resources */ = {isa = PBXBuildFile; fileRef = 8D381B601FD9F5B1008D5A58 /* noDestinationName.json */; };
Expand Down Expand Up @@ -348,8 +344,7 @@
438BFEC0233D805500457294 /* README.md */ = {isa = PBXFileReference; lastKnownFileType = net.daringfireball.markdown; path = README.md; sourceTree = "<group>"; };
438BFEC1233D854D00457294 /* DirectionsProfileIdentifier.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = DirectionsProfileIdentifier.swift; sourceTree = "<group>"; };
4392557523440EC2006EEE88 /* DirectionsError.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = DirectionsError.swift; sourceTree = "<group>"; };
43F89F922350F952007B591E /* MatchResponse.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MatchResponse.swift; sourceTree = "<group>"; };
43F89F97235778DE007B591E /* MapMatchingResponse.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MapMatchingResponse.swift; sourceTree = "<group>"; };
43F89F922350F952007B591E /* MapMatchingResponse.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MapMatchingResponse.swift; sourceTree = "<group>"; };
8D381B601FD9F5B1008D5A58 /* noDestinationName.json */ = {isa = PBXFileReference; lastKnownFileType = text.json; path = noDestinationName.json; sourceTree = "<group>"; };
8D381B621FDB01D1008D5A58 /* apiDestinationName.json */ = {isa = PBXFileReference; explicitFileType = text.json; path = apiDestinationName.json; sourceTree = "<group>"; };
8D381B691FDB101F008D5A58 /* String.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = String.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -585,10 +580,9 @@
C5DAAC9E20191683001F9261 /* MapMatching */ = {
isa = PBXGroup;
children = (
43F89F97235778DE007B591E /* MapMatchingResponse.swift */,
C5DAAC9920191675001F9261 /* Match.swift */,
C5434B8B200695A50069E887 /* MatchOptions.swift */,
43F89F922350F952007B591E /* MatchResponse.swift */,
43F89F922350F952007B591E /* MapMatchingResponse.swift */,
C5434B89200693D00069E887 /* Tracepoint.swift */,
);
path = MapMatching;
Expand Down Expand Up @@ -1179,7 +1173,6 @@
35DBF010217E17A30009D2AE /* HTTPURLResponse.swift in Sources */,
8D43467A219E15C3008B7BF3 /* Double.swift in Sources */,
C53A02261E92C26E009837BD /* AttributeOptions.swift in Sources */,
43F89F99235778DE007B591E /* MapMatchingResponse.swift in Sources */,
DA1A10C91D00F969009F82FA /* RouteLeg.swift in Sources */,
C52552BA1FA15D5E00B1545C /* VisualInstructionBanner.swift in Sources */,
35828C9F217A003F00ED546E /* OfflineDirections.swift in Sources */,
Expand All @@ -1199,7 +1192,7 @@
431E93D023466D7500A71B44 /* Codable.swift in Sources */,
C5990B4D2045E74800D7DFD4 /* DirectionsOptions.swift in Sources */,
DAA76D691DD127CB0015EC78 /* LaneIndication.swift in Sources */,
43F89F942350F952007B591E /* MatchResponse.swift in Sources */,
43F89F942350F952007B591E /* MapMatchingResponse.swift in Sources */,
DA1A10CB1D00F969009F82FA /* RouteStep.swift in Sources */,
C57D55031DB566A700B94B74 /* Intersection.swift in Sources */,
C52CE38F1F6AF63C0069963D /* SpokenInstruction.swift in Sources */,
Expand Down Expand Up @@ -1252,7 +1245,6 @@
35DBF011217E17A30009D2AE /* HTTPURLResponse.swift in Sources */,
8D43467B219E15C4008B7BF3 /* Double.swift in Sources */,
C53A02271E92C26F009837BD /* AttributeOptions.swift in Sources */,
43F89F9A235778DE007B591E /* MapMatchingResponse.swift in Sources */,
DA1A10EF1D010247009F82FA /* RouteLeg.swift in Sources */,
C52552BB1FA15D5F00B1545C /* VisualInstructionBanner.swift in Sources */,
35828CA0217A003F00ED546E /* OfflineDirections.swift in Sources */,
Expand All @@ -1272,7 +1264,7 @@
431E93D123466D7600A71B44 /* Codable.swift in Sources */,
C5990B4E2045E74900D7DFD4 /* DirectionsOptions.swift in Sources */,
DAA76D6A1DD127CB0015EC78 /* LaneIndication.swift in Sources */,
43F89F952350F952007B591E /* MatchResponse.swift in Sources */,
43F89F952350F952007B591E /* MapMatchingResponse.swift in Sources */,
DA1A10F11D010247009F82FA /* RouteStep.swift in Sources */,
C57D55041DB566A800B94B74 /* Intersection.swift in Sources */,
C52CE3901F6AF63D0069963D /* SpokenInstruction.swift in Sources */,
Expand Down Expand Up @@ -1325,7 +1317,6 @@
35DBF012217E17A30009D2AE /* HTTPURLResponse.swift in Sources */,
8D43467C219E15C6008B7BF3 /* Double.swift in Sources */,
C53A02281E92C271009837BD /* AttributeOptions.swift in Sources */,
43F89F9B235778DE007B591E /* MapMatchingResponse.swift in Sources */,
DA1A11061D0103A3009F82FA /* RouteLeg.swift in Sources */,
C52552BC1FA15D6000B1545C /* VisualInstructionBanner.swift in Sources */,
35828CA1217A003F00ED546E /* OfflineDirections.swift in Sources */,
Expand All @@ -1345,7 +1336,7 @@
431E93D223466D7700A71B44 /* Codable.swift in Sources */,
C5990B4F2045E74A00D7DFD4 /* DirectionsOptions.swift in Sources */,
DAA76D6B1DD127CB0015EC78 /* LaneIndication.swift in Sources */,
43F89F962350F952007B591E /* MatchResponse.swift in Sources */,
43F89F962350F952007B591E /* MapMatchingResponse.swift in Sources */,
DA1A11081D0103A3009F82FA /* RouteStep.swift in Sources */,
C57D55051DB566A900B94B74 /* Intersection.swift in Sources */,
C52CE3911F6AF63E0069963D /* SpokenInstruction.swift in Sources */,
Expand All @@ -1371,7 +1362,6 @@
8D434679219E1167008B7BF3 /* Double.swift in Sources */,
DA2E03EB1CB0E13D00D1269A /* RouteOptions.swift in Sources */,
C582BA2E2073ED6300647DAA /* Array.swift in Sources */,
43F89F98235778DE007B591E /* MapMatchingResponse.swift in Sources */,
C52552B91FA15D5900B1545C /* VisualInstructionBanner.swift in Sources */,
35828C9E217A003F00ED546E /* OfflineDirections.swift in Sources */,
DAE7EA94230B5FD10003B211 /* Measurement.swift in Sources */,
Expand All @@ -1390,7 +1380,7 @@
431E93CF23466D7400A71B44 /* Codable.swift in Sources */,
C59094C1203DE6BC00EB2417 /* DirectionsResult.swift in Sources */,
DAC05F1A1CFC077C00FA0071 /* RouteLeg.swift in Sources */,
43F89F932350F952007B591E /* MatchResponse.swift in Sources */,
43F89F932350F952007B591E /* MapMatchingResponse.swift in Sources */,
C5434B8A200693D00069E887 /* Tracepoint.swift in Sources */,
DA6C9DA61CAE462800094FBC /* Directions.swift in Sources */,
C55FB44B1F6AEBF6006BD1E9 /* SpokenInstruction.swift in Sources */,
Expand Down
Loading