Update OkHttp version to 3.10.0 #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…workaround stuck mockwebserver tests after bumping okhttp version to 3.10.0
electrostat
reviewed
Mar 2, 2018
| import okhttp3.HttpUrl; | ||
| import okhttp3.internal.tls.SslClient; | ||
| import okhttp3.mockwebserver.internal.tls.SslClient; |
There was a problem hiding this comment.
Should we continue to use an internal api if future changes could cause issues similar issues? Is there any way we can get rid of this?
There was a problem hiding this comment.
Here is a bit different because MockWebServer is only used for testing. So although APIs could change it's not a problem because it's not affecting production code which is what we're exposing and what could cause issues in the future. Does that make sense?
There was a problem hiding this comment.
Is there any way we can get rid of this?
Nope, it's actually needed for testing HTTP requests.
There was a problem hiding this comment.
Makes sense. Sounds good.
| import okhttp3.Call; | ||
| import okhttp3.Callback; | ||
| import okhttp3.HttpUrl; | ||
| import okhttp3.OkHttpClient; | ||
| import okhttp3.Response; | ||
| import okhttp3.internal.tls.SslClient; | ||
| import okhttp3.mockwebserver.internal.tls.SslClient; |
There was a problem hiding this comment.
Already answered ☝️
electrostat
approved these changes
Mar 2, 2018
electrostat
pushed a commit
that referenced
this pull request
Mar 22, 2018
* bump okhttp version to 3.10.0 * add hostname verifier to telemetry client settings builder needed to workaround stuck mockwebserver tests after bumping okhttp version to 3.10.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.10.0hostnameVerifiertoTelemetryClientSettingsbuilder needed to workaround stuck MockWebServer tests after bumping OkHttp version to3.10.0. For further details 👉 MockWebServer tests got stuck after updating from 3.9.1 to 3.10.0 square/okhttp#3898cc @electrostat @zugaldia @tobrun @LukasPaczos