Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POI icons are blurry #124

Closed
kkaefer opened this issue Oct 14, 2013 · 4 comments
Closed

POI icons are blurry #124

kkaefer opened this issue Oct 14, 2013 · 4 comments
Labels

Comments

@kkaefer
Copy link
Member

kkaefer commented Oct 14, 2013

With the new changes, the POI icons are blurry. Also, they're way too small on retina screens.

@ansis
Copy link
Contributor

ansis commented Oct 14, 2013

#102 would be one approach to fixing this for unscaled/unrotated icons.

As you mentioned, using sdf for things like oneway arrows would be great. This probably won't help with maki blurriness though.

@ansis
Copy link
Contributor

ansis commented Oct 15, 2013

Retina icon regression fixed in 874b8ac

@ansis
Copy link
Contributor

ansis commented Oct 25, 2013

4d496b4 fixes most blurriness by using linear filtering only when the icon is rotated (line markers) or when the map is rotating (to prevent jiggling). The switch between linear/nearest is slightly noticeable, but this isn't something that can be avoided.

Splitting support for sdf incons into #161. sdf will be useful, but won't help reduce blurriness for complex icons that are as small as what we're currently using (12px).

@ansis ansis closed this as completed Oct 25, 2013
@kkaefer
Copy link
Member Author

kkaefer commented Oct 25, 2013

Can we turn on linear filtering when the user is zooming, and back off if zooming stipped? Otherwise you'll still see a slight jiggle effect when zooming with the trackpad.

@ansis ansis reopened this Oct 25, 2013
@ansis ansis closed this as completed in 3cef2f1 Oct 25, 2013
ansis added a commit that referenced this issue Jan 13, 2014
bensleveritt pushed a commit to bensleveritt/mapbox-gl-js that referenced this issue Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants