Allow adding multiple layers to map.on() event handler (h/t @omerbn)
#11114
Conversation
| * If a single `layerId`(as a single string) or multiple `layerIds` (as an array of strings) was specified when adding the event listener with {@link Map#on}, | ||
| * `features` will be an array of [GeoJSON](http://geojson.org/) [Feature objects](https://tools.ietf.org/html/rfc7946#section-3.2). | ||
| * The array will contain all features from that layer that are rendered at the event's point, | ||
| * in the order that they are rendered with the topmost feature being at the start of the array. |
There was a problem hiding this comment.
in the order that they are rendered with the topmost feature being at the start of the array.
Is this new statement well tested?
I'm curious if the following unit test still returns the right order if we have ['A1', 'A2'] as layer order and request:
map.on(event, ['A2', 'A1'], spy);
instead of
map.on(event, ['A1', 'A2'], spy);
There was a problem hiding this comment.
The new unit tests add tests which correctly test if the array is being correctly sent over to the layers property in map.queryRenderedFeatures(pt, {layers: []) and thats what handles the actual ordering of the features. We have a bunch of tests for that in the query test suite.
…-multiple-layers-to-map-events
* main: Add touch pan blocker to gesture handling for touch devices (#11116) Address accessibility issues (#11064) add support for non-mercator projections (#11124) Image fallback expressions within paint properties (#11049) Replaces EPSG:4326 with OGC:CRS84 in GL JS `LngLat` doc (#11072) Add globe view support to heatmap shaders (#11120) Exclude flaky test (#11118) consistify YOUR_MAPBOX_ACCESS_TOKEN as placeholder string (#11113) Allow adding multiple layers to `map.on()` event handler (h/t @omerbn) (#11114) render-test-flakiness:clear worker storage (#11111) upgrade to supercluster v7.1.4, earcut v2.2.3, vt-pbf v3.1.3, geojson-rewind v0.5.1 (#11110) Added v1.13.2 changelog entry (#11108) One weird JSON.parse() trick (#11098) Fixed doc usage of map.getCenter (#11093) s̶y̶m̶b̶o̶l̶-̶c̶l̶i̶p̶ dynamic-filtering with `pitch` and `distance-from-camera` expressions (#10795) Update link to transpiling guide (#11096) Cherry pick 2.5.1 changelog (#11099) Fix an iOS15 issue where Safari tab bar interrupts panning (#11084) Fix conditional check for isFullscreen to accommodate Safari (#11086) Render tests for #11041 (#11070)
|
I take it this was only done on the v2 branch? I wanted to share an event listener across multiple layers, so I tried adding it using an array of layer IDs on a project using the v1 API. But the listener never fires. No errors, either. It seems to only work when a single layer ID string is passed to |
Closes #9995
and adding a small tweak to what @omerbn already did over in #10954.
Launch Checklist
mapbox-gl-jschangelog:<changelog>Add support for attaching events to multiple layers withmap.on(), allowing users to get retrieve features under the mouse or touch event based on the order in which they are rendered. </changelog>