include MouseEvents polyfill to allow map rotation via compass button on IE11 #4843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the dependency is minimal, it can be ok to use local conditionals like |
|
sorry I haven't had the time to work on this, good to see progress in #5157 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4784
Launch Checklist
briefly describe the changes in this PR
This PR include a MouseEvents polyfill to fix Navigation Control compass click event IE 11 throws: Object doesn't support this action #4784. What's the feeling towards using polyfills in GL JS to maintain support for older browsers?
write tests for all new functionality
This change seems to break a whole lot of tests, I can look into that once I get feedback on if this approach will be accepted or not.
document any changes to public APIs
post benchmark scores
manually test the debug page
tested before and after on IE11.