This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Add isLayerReady check in LocationComponent before updating compass listener. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While trying to reproduce the user reported issue, I have found another issue related to trying to use the style while it's in invalidate state. Created another issue to follow up at #20 |
LukasPaczos
reviewed
Oct 22, 2019
...tApp/src/main/java/com/mapbox/mapboxsdk/testapp/activity/location/LocationModesActivity.java
Show resolved
Hide resolved
MapboxGLAndroidSDK/src/test/java/com/mapbox/mapboxsdk/location/LocationComponentTest.kt
Outdated
Show resolved
Hide resolved
MapboxGLAndroidSDK/src/test/java/com/mapbox/mapboxsdk/location/LocationComponentTest.kt
Outdated
Show resolved
Hide resolved
pengdev
force-pushed
the
peng-fix-location-component-updating-compass
branch
from
87b1e16
to
8c398de
Compare
LukasPaczos
approved these changes
Oct 22, 2019
MapboxGLAndroidSDK/src/test/java/com/mapbox/mapboxsdk/location/LocationComponentTest.kt
Outdated
Show resolved
Hide resolved
pengdev
force-pushed
the
peng-fix-location-component-updating-compass
branch
from
8c398de
to
c80ae81
Compare
|
@LukasPaczos when will this be released? |
|
@oantajames you can test the changes with |
|
any updates on the stable release? Also it seem's like there's no v8.5.0-beta.1. Only 8.5.0-alpha.1 or 8.5.0-alpha.2 @LukasPaczos |
|
@oantajames it has been released, see https://search.maven.org/artifact/com.mapbox.mapboxsdk/mapbox-android-sdk/8.5.0-beta.1 |
|
Thanks @tobrun |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves mapbox/mapbox-gl-native#14889