This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
[surface] exception free GLSurfaceView implementation #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
force-pushed
the
tvn-glsurfaceview
branch
3 times, most recently
from
3f3ddb8 to
ed329b0
Compare
Chaoba
reviewed
May 28, 2020
MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/renderer/egl/EGLContextFactory.java
Show resolved
Hide resolved
...dSDK/src/main/java/com/mapbox/mapboxsdk/maps/renderer/glsurfaceview/MapboxGLSurfaceView.java
Outdated
Show resolved
Hide resolved
...dSDK/src/main/java/com/mapbox/mapboxsdk/maps/renderer/glsurfaceview/MapboxGLSurfaceView.java
Outdated
Show resolved
Hide resolved
Chaoba
approved these changes
May 29, 2020
emerson233
pushed a commit
to emerson233/mapbox-gl-native-android
that referenced
this pull request
Jul 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<changelog>Introduced an exception free GLSurfaceView implementation.</changelog>This PR replaces the Android SDK GLSurfaceView implementation by a custom, exception free, variant. We have seen client reports where devices are not capable of loading up a map and instead of crashing (as with the default GLSurfaceView), we are now exiting the initialization flow more gracefully.
cc @mapbox/maps-android