Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Set gps bearing immediately while changing to gps mode. #470

Merged
merged 1 commit into from
Jul 15, 2020

Conversation

Chaoba
Copy link
Contributor

@Chaoba Chaoba commented Jul 13, 2020

Cache gps bearing while in normal and compass mode and then set it to render when changing to GPS mode.
Resolves #462

@Chaoba Chaoba requested a review from a team July 13, 2020 11:27
@Chaoba Chaoba self-assigned this Jul 13, 2020
@Chaoba Chaoba requested a review from LukasPaczos July 13, 2020 11:28
Copy link

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test?

One comment below as a possible alternative, not blocking if there's no clear way of achieving it.

@Chaoba Chaoba changed the title Cache bearing for gps mode. Set gps bearing immediately while changing to gps mode. Jul 14, 2020
@Chaoba
Copy link
Contributor Author

Chaoba commented Jul 14, 2020

@LukasPaczos Rethink about it and found a new solution to set lastLocation's bearing while change to GPS mode. Also found if it has ANIMATOR_LAYER_GPS_BEARING animator, it will start the animation from this animator value to the new location bearing, so remove this animator to eliminate the catch-up animation.

@Chaoba Chaoba merged commit e443fe9 into master Jul 15, 2020
@Chaoba Chaoba deleted the kl-puck-bearing branch July 15, 2020 11:30
tobrun added a commit that referenced this pull request Jul 15, 2020
* [docs] update changelog for release-xoai final

* Set gps bearing immediately while change to gps mode (#470)

Co-authored-by: kevin <kevin.li@mapbox.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GPS puck keeps previous value when enabled
2 participants