This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Update accessibility calcs #319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianrex
force-pushed
the
jrex/update-accessibility-calcs-pt2
branch
from
d5a820f to
5cb4502
Compare
julianrex
force-pushed
the
jrex/update-accessibility-calcs
branch
from
b90b5df to
4e9878d
Compare
This was referenced Jun 15, 2020
julianrex
force-pushed
the
jrex/update-accessibility-calcs-pt2
branch
from
5cb4502 to
f1d59aa
Compare
jmkiley
approved these changes
Jun 22, 2020
jmkiley
force-pushed
the
jrex/update-accessibility-calcs
branch
from
c583c75 to
fb30ebf
Compare
jmkiley
force-pushed
the
jrex/update-accessibility-calcs
branch
from
fb30ebf to
08d4f21
Compare
Base automatically changed from
jrex/update-accessibility-calcs
to
jrex/query-tests
July 8, 2020 00:17
…eatures for abbreviated "places visible"
jmkiley
force-pushed
the
jrex/update-accessibility-calcs-pt2
branch
from
f1d59aa to
46a8b54
Compare
|
Most of the changes here took place in #318 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 3 of 3 PRs that port mapbox/mapbox-gl-native#15303 to this repo. (See also #317, #318.)
This PR checks the visibility of the compass to decide whether it should be included in accessibility elements (before it was always included).
It also uses the sorted (by distance from center or user location view) place names in the abbreviated description. This may not be a change that we want to include at this time.