Gesture delay while zooming in/out #10102
Comments
|
Thank you for writing up this ticket @paulVulog. First want to clarify there isn't any difference in the gesture performance (in which I mean the time needed to execute a gesture). The difference you are noticing is the change in touch slop (the barrier the touch interaction need to cross before executing the gesture). The code related to this can be found here. I'm unable to revert that value back to half as this wasn't working correctly with the issue the PR was solving. I'm now looking into finding a value in between that provides a better UX for the issue in OP + that works well with the issue #10026 was solving. |
|
in #10134 I have fine tuned the gesture variables. Are you able to test this? Once merged, this will be available in the 5.2.0-SNAPSHOT build. |
|
@paulVulog re. |
|
Hi @tobrun, for the first issue (delay) I don't know if the snapshot already contains the last fix, but it's definitely better than the 5.1.4 version. (the delay is now acceptable !) For the second issue, here are my findings (version 5.1.4 -> Nexus 5x (Oreo)): First, let's split the zoom behavior in three gestures :
I will link my findings to the three listeners : 1 - The Tap & Drag gesture : 2 - The Double Tap 3 - The Pinch gesture
|
|
Hi ! |
|
Sorry for the delay on this. re.
@paulVulog : could you please add steps for a reproducible test for |
|
Hi @tobrun, Regarding the pinch gesture issue, this is exactly what you are targetting : #8403
So at the end it is an Android issue and we can do almost nothing :( Regarding the Double tap gesture, I was not clear enough. The Double Tap to zoom in works fine ( one finger gesture ) Let me know if I am not clear enough. |
|
@paulVulog thank you for the clarification, for the 5.2.0 release the double tap zoom out doesn't seem to be broken: Will look into reproducing with the 5.1.4 codebase. |
|
With the 5.1.4 codebase I'm seeing output as: So this indicates to me that everything is working as expected. We are currently working on something else related to gestures (adding velocity), feel free to look into the PR here and provide feedback. Long term goal is to rewrite gestures from scratch in #10016. Thank you for reaching out but closing as not reproducible or not actionable (scalegesturedetector issue). |
Hi
I just updated from 5.1.3 to 5.1.4 and the zoom function gesture performance are worst than before.
It takes around 500ms delay for the map to start the zoom after the gesture. It was not the case before ( tested with nexus5x and galaxyS5 ). Moreover I am no more able to completely zoom out. At some point I am blocked and I need to start a new gesture to zoom out again.
Same issue regqrding the delay with the 5.2.0-SNAPSHOT. (but less delay - around 200ms);
Edit:
The zoom seems not blocked with the snapshot version.The zoom level is blocked at some point with a single gesture on the snapshot version too.
Using the same devices with the mapbox demo app (version 5.1.3) I get no delay at all during the gesture.
However, regarding this closed issue #9413, it's definitely better. I can now zoom and drag at the same time ;)
This issue is originated from : #10026
The text was updated successfully, but these errors were encountered: