Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Static analysis warnings in MGLComputedShapeSource.mm #10571

Closed
akitchen opened this issue Nov 27, 2017 · 0 comments · Fixed by #10582
Closed

Static analysis warnings in MGLComputedShapeSource.mm #10571

akitchen opened this issue Nov 27, 2017 · 0 comments · Fixed by #10582
Assignees

Comments

@akitchen
Copy link
Contributor

The changes in #9983 introduce three static analysis warnings in MGLComputedShapeSource.mm.

In -[MGLComputedShapeSource initWithIdentifier:options:] we are referencing self and an instance variable before self is initialized. This should be simple enough to address with a refactoring to use a local variable for requestQueue, setting _requestQueue = requestQueue once self is initialized.

The other two warnings are less obvious to me (1st function call argument is an uninitialized value (within a call to '~variant')).

/cc @asheemmamoowala

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant