You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
The changes in #9983 introduce three static analysis warnings in MGLComputedShapeSource.mm.
In -[MGLComputedShapeSource initWithIdentifier:options:] we are referencing self and an instance variable before self is initialized. This should be simple enough to address with a refactoring to use a local variable for requestQueue, setting _requestQueue = requestQueue once self is initialized.
The other two warnings are less obvious to me (1st function call argument is an uninitialized value (within a call to '~variant')).
The changes in #9983 introduce three static analysis warnings in
MGLComputedShapeSource.mm
.In
-[MGLComputedShapeSource initWithIdentifier:options:]
we are referencingself
and an instance variable beforeself
is initialized. This should be simple enough to address with a refactoring to use a local variable forrequestQueue
, setting_requestQueue = requestQueue
onceself
is initialized.The other two warnings are less obvious to me (
1st function call argument is an uninitialized value (within a call to '~variant')
)./cc @asheemmamoowala
The text was updated successfully, but these errors were encountered: