Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios,android] Implement local ideographic glyph generation for MapSnapshotter #10665

Closed
ChrisLoer opened this issue Dec 8, 2017 · 5 comments
Closed
Labels
Core The cross-platform C++ core, aka mbgl performance Speed, stability, CPU usage, memory usage, or power usage

Comments

@ChrisLoer
Copy link
Contributor

#10522 introduces support for local generation of ideographic glyphs. For maps that use lots of CJK glyphs, this can lead to a dramatic reduction in data usage. The Android and iOS implementations of MapSnapshotter don't currently take advantage of this setting, so for a CJK user using the local override, a map might load with 1MB worth of data, but taking a snapshot of that map might require downloading an extra 10MB of glyph data.

HeadlessFrontend already supports a localFontFamily argument, so the only change to portable code required here is to pass that argument through the MapSnapshotter constructor.

The Android implementation will need to expose an appropriate option to the Java MapSnapshotter class. The iOS implementation may take advantage of the existing MGLIdeographicFontFamily setting in Info.plist.

@ChrisLoer
Copy link
Contributor Author

@1ec5 1ec5 added Core The cross-platform C++ core, aka mbgl performance Speed, stability, CPU usage, memory usage, or power usage labels Dec 9, 2017
@stale stale bot added the archived Archived because of inactivity label Nov 2, 2018
@stale
Copy link

stale bot commented Dec 4, 2018

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Dec 4, 2018
@zugaldia zugaldia reopened this Dec 6, 2018
@stale stale bot removed the archived Archived because of inactivity label Dec 6, 2018
@zugaldia
Copy link
Member

zugaldia commented Dec 6, 2018

MapSnapshotter is actively used with maps that use CJK glyphs, I understand this is an improvement we still want to do. Tagging @chloekraw for confirmation and prioritization.

@chriswu42
Copy link

@ChrisLoer can you verify that this work is now completed?

@ChrisLoer
Copy link
Contributor Author

Yup, we just fixed this with #13427, we just forgot about the tracking issue!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core The cross-platform C++ core, aka mbgl performance Speed, stability, CPU usage, memory usage, or power usage
Projects
None yet
Development

No branches or pull requests

4 participants