Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Remove LatLng wrapping #13149

Closed
tobrun opened this issue Oct 22, 2018 · 2 comments · Fixed by #13419
Closed

Remove LatLng wrapping #13149

tobrun opened this issue Oct 22, 2018 · 2 comments · Fixed by #13419
Assignees
Labels
Android Mapbox Maps SDK for Android SEMVER-MAJOR Requires a major release according to Semantic Versioning rules

Comments

@tobrun
Copy link
Member

tobrun commented Oct 22, 2018

We initially added LatLng wrapping to be on par with logic exposed by the Google Maps SDK. Going forward we prefer having parity with core and gl-js. With next semver major update we are going to remove LatLng wrapping from the Android SDK.

@tobrun tobrun added Android Mapbox Maps SDK for Android SEMVER-MAJOR Requires a major release according to Semantic Versioning rules labels Oct 22, 2018
@tobrun tobrun added this to the android-v7.0.0 milestone Oct 22, 2018
@LukasPaczos LukasPaczos assigned osana and unassigned LukasPaczos Nov 12, 2018
@osana
Copy link
Contributor

osana commented Nov 21, 2018

@tobrun @LukasPaczos

Just want to double check that with wrapping removed

The following code will create bounds: NorthEast 10, 170 and SouthWes -10, -170 which will be the opposite of what it was doing before as the shortest span (i.e.wrapping is not honored)
new LatLngBounds.Builder()
.include(new LatLng(10, -170))
.include(new LatLng(-10, 170))
.build();

@LukasPaczos
Copy link
Contributor

This looks reasonable to me. With unwrapped values allowed, users can extend longitudes over 180/-180 and create short spanned bounds.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android SEMVER-MAJOR Requires a major release according to Semantic Versioning rules
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants