Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

add Settings.bundle to distribution? #2380

Closed
incanus opened this issue Sep 22, 2015 · 4 comments
Closed

add Settings.bundle to distribution? #2380

incanus opened this issue Sep 22, 2015 · 4 comments
Labels
build iOS Mapbox Maps SDK for iOS

Comments

@incanus
Copy link
Contributor

incanus commented Sep 22, 2015

Should we add our settings bundle to the binary and CocoaPods distributions to ease installation for folks who need it?

/cc @friedbunny @1ec5

@incanus incanus added iOS Mapbox Maps SDK for iOS build labels Sep 22, 2015
@1ec5
Copy link
Contributor

1ec5 commented Sep 22, 2015

Yes, let’s include the example settings bundle in the binary. It’ll get pulled down by CocoaPods, too, but I don’t think we need to have CocoaPods automatically add it to the host application target.

@incanus
Copy link
Contributor Author

incanus commented Sep 22, 2015

Right, I agree, because it could clobber a user’s existing bundle.

@friedbunny
Copy link
Contributor

Yes, we should include the example Settings.bundle in the pod and binary distributions — will remove a small amount of friction in our setup process, I think.

@1ec5
Copy link
Contributor

1ec5 commented Jan 23, 2016

Added in f2a28f0. Added a better way in #3183.

@1ec5 1ec5 closed this as completed Jan 23, 2016
@1ec5 1ec5 changed the title add Settings.bundle to distribution? add Settings.bundle to distribution? Jan 23, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build iOS Mapbox Maps SDK for iOS
Projects
None yet
Development

No branches or pull requests

3 participants