Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Android Telemetry User Opt Out UI #3907

Closed
bleege opened this issue Feb 11, 2016 · 8 comments
Closed

Android Telemetry User Opt Out UI #3907

bleege opened this issue Feb 11, 2016 · 8 comments
Assignees
@bleege
Labels
Android Mapbox Maps SDK for Android telemetry Integration with Mapbox Telemetry libraries
Milestone
android-v4.0.0

Comments

@bleege
Copy link
Contributor

bleege commented Feb 11, 2016

Users of apps running Mapbox Android SDK should always have the ability to opt out of Telemetry data collection.

This ticket will be about building an Opt Out control into the Mapbox Android TestApp that can be used as an example to implementing developers of how to do this.
@bleege bleege added Android Mapbox Maps SDK for Android telemetry Integration with Mapbox Telemetry libraries labels Feb 11, 2016
@bleege bleege self-assigned this Feb 11, 2016
@bleege bleege added this to the android-v4.0.0 milestone Feb 11, 2016
@bleege bleege mentioned this issue Feb 11, 2016
Closed
3 tasks
@mikemorris
Copy link
Contributor

On iOS, we moved the telemetry opt-out into the ℹ️ button so that developers integrating the SDK don't have to go through an extra step of configuring their own opt-out - it's just there already by default.

bleege added a commit that referenced this issue Feb 11, 2016
@bleege
[android] #3907 - Adding Telemetry Settings to Attribution Options
80cfa0e
@bleege
Copy link
Contributor Author

bleege commented Feb 11, 2016

Will follow iOS lead and build this into the MapView itself. Here's what it'll look like on the Map Attribution list:

device-2016-02-11-121108

bleege added a commit that referenced this issue Feb 12, 2016
@bleege
[android] #3907 - Initial refactoring to support on / off capability …
cd21bfc 
…for Telemetry Services
bleege added a commit that referenced this issue Feb 12, 2016
@bleege
[android] #3907 - Integrating Telemetry On / Off UI with functionality
e640a9d
bleege added a commit that referenced this issue Feb 12, 2016
@bleege
[android] #3907 - Clearing any / all events in memory at the time of …
74e192b 
…Telemetry being disabled
@bleege bleege mentioned this issue Feb 12, 2016
Closed
@bleege
Copy link
Contributor Author

bleege commented Feb 12, 2016

Refactored Telemetry infrastructure to support enabling and disabling. Added UI to allow end users to toggle between the two choices. The choice is persisted in the SDK's private SharedPreferences file.

device-2016-02-11-182732
UI To Enable / Disable Telemetry

bleege added a commit that referenced this issue Feb 12, 2016
@bleege
[android] #3907 - Adding Telemetry Settings to Attribution Options
cd951e2
bleege added a commit that referenced this issue Feb 12, 2016
@bleege
[android] #3907 - Initial refactoring to support on / off capability …
23bde21 
…for Telemetry Services
bleege added a commit that referenced this issue Feb 12, 2016
@bleege
[android] #3907 - Integrating Telemetry On / Off UI with functionality
37d6a47
bleege added a commit that referenced this issue Feb 12, 2016
@bleege
[android] #3907 - Clearing any / all events in memory at the time of …
076f29c 
…Telemetry being disabled
@bleege
Copy link
Contributor Author

bleege commented Feb 12, 2016

Tested, Rebased, and Merged! ☑️

@bleege bleege closed this as completed Feb 12, 2016
lgeromegnace pushed a commit to Mappy/mapbox-gl-native that referenced this issue Feb 12, 2016
Merge branch 'master' into mappy
c9af71d 
* master: (144 commits)
  [android] mapbox#3900 - Using CopyWriteArrayList to avoid concurrency issues with MapChangeListeners
  [android] mapbox#3919 - restore espresso tests
  [android] mapbox#3907 - Clearing any / all events in memory at the time of Telemetry being disabled
  [android] mapbox#3907 - Integrating Telemetry On / Off UI with functionality
  [android] mapbox#3907 - Initial refactoring to support on / off capability for Telemetry Services
  [android] mapbox#3907 - Adding Telemetry Settings to Attribution Options
  [tests] Fix build
  [core] Organize files that were in map folder better
  Allow using tileSize: 512 as a switch to trade retina support for 512px raster tiles
  [android] mapbox#3908 - No more beep
  [build] Build `offline` tool on the bots
  [build] Fix broken target when building on the bots
  [build] Build `offline` smoke test for Linux
  [android] mapbox#3876 - rename InfoWindowClickListener method
  [android] mapbox#3895 - handles the case of not requested/accepted permissions
  [core] use std::move() to prevent copies
  [core] return std::move() prevents copy elision
  [android] mapbox#2421 - Adding basic JavaDocs
  [android] mapbox#2421 - Setting up Certificate Pinning for Prod Server GeoTrust
  [android] mapbox#2421 - Setting up Certificate Pinning for Staging Server
  ...
@bleege
Copy link
Contributor Author

bleege commented Feb 12, 2016

As @mikemorris points out I forgot to put Telemetry explanatory text into the dialog. Will take care of that.

@bleege bleege reopened this Feb 12, 2016
@bleege
Copy link
Contributor Author

bleege commented Feb 12, 2016

Goal -->

screen shot 2016-02-12 at 9 52 28 am

bleege added a commit that referenced this issue Feb 13, 2016
@bleege
[android] #3907 - Adding Telemetry description to dialog
d4b7570
@bleege bleege mentioned this issue Feb 13, 2016
Closed
@bleege
Copy link
Contributor Author

bleege commented Feb 13, 2016

Added description to mirror content and layout of iOS.

screen shot 2016-02-12 at 4 23 07 pm

bleege added a commit that referenced this issue Feb 13, 2016
@bleege
[android] #3907 - Adding Telemetry description to dialog
9841f94
@bleege
Copy link
Contributor Author

bleege commented Feb 13, 2016

Tested, Rebased, and Merged.

@bleege bleege closed this as completed Feb 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bleege bleege

Labels
Android Mapbox Maps SDK for Android telemetry Integration with Mapbox Telemetry libraries
Projects
None yet
Milestone
android-v4.0.0
Development

No branches or pull requests
4 participants
@jfirebaugh @lucaswoj @bleege @mikemorris